Statistics
| Branch: | Revision:

root / hw / pc_sysfw.c @ 5e22c276

History | View | Annotate | Download (7.8 kB)

# Date Author Comment
e7b1d0ea 01/04/2013 03:38 pm Markus Armbruster

pc_sysfw: Check for qemu_find_file() failure

pc_fw_add_pflash_drv() ignores qemu_find_file() failure, and happily
creates a drive without a medium.

When pc_system_flash_init() asks for its size, bdrv_getlength() fails
with -ENOMEDIUM, which isn't checked either. It fails relatively...
9c17d615 12/19/2012 09:32 am Paolo Bonzini

softmmu: move include files to include/sysemu/

Signed-off-by: Paolo Bonzini <>
2d0d2837 12/11/2012 12:05 pm Christian Borntraeger

Support default block interfaces per QEMUMachine

There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a
default/standard interface to their block devices / drives. Therefore,
this patch introduces a new field default_block_type per QEMUMachine
struct. The prior use_scsi field becomes thereby obsolete and is...
654598c9 12/07/2012 01:34 pm Markus Armbruster

pc_sysfw: Plug memory leak on pc_fw_add_pflash_drv() error path

Harmless, because we the error inevitably leads to another, fatal one
in pc_system_flash_init(): PC system firmware (pflash) not available.
Fix it anyway.

Signed-off-by: Markus Armbruster <>...
a8170e5e 10/23/2012 04:58 pm Avi Kivity

Rename target_phys_addr_t to hwaddr

target_phys_addr_t is unwieldly, violates the C standard (_t suffixes are
reserved) and its purpose doesn't match the name (most target_phys_addr_t
addresses are not target specific). Replace it with a finger-friendly,...
dfc65f1f 06/15/2012 03:03 pm Markus Armbruster

Un-inline fdctrl_init_isa()

Signed-off-by: Markus Armbruster <>
Reviewed-by: Anthony Liguori <>
Signed-off-by: Kevin Wolf <>
9cf1f002 05/03/2012 08:04 am Stefan Weil

hw/pc_sysfw: Fix memory leak

Valgrind reported this memory leak which occured a few times.

Test scenario:

qemu-system-i386 (no arguments), only BIOS started, terminate with
monitor command (quit).

Signed-off-by: Stefan Weil <>
Reviewed-by: Andreas Färber <>
1d38574f 04/26/2012 09:14 pm Anthony Liguori

pc-sysfw: make sure to call qdev_init

We're not actually calling qdev_init for the pc-sysfw device. Since we create
the canonical path during realize, this was causing an assert to trigger when
attempting to read a link pointing to pc-sysfw.

Signed-off-by: Anthony Liguori <>
90ccf9f6 02/22/2012 05:02 pm Jordan Justen

hw/pc_sysfw: enable pc-sysfw as a qdev

Setup a pc-sysfw device type. It contains a single
property of 'rom_only' which is defaulted to enabled.

Signed-off-by: Jordan Justen <>
Signed-off-by: Anthony Liguori <>
bd183c79 02/22/2012 05:02 pm Jordan Justen

hw/pc_sysfw: support system flash memory with pflash

Flash can be enabled by calling pc_system_firmware_init
with the system_flash_enabled parameter being non-zero.
If system_flash_enabled is zero, then the older qemu
rom creation method will be used.

If flash is enabled and a pflash image is found, then...
1b89fafe 02/22/2012 05:02 pm Jordan Justen

pc_piix/pc_sysfw: enable flash by default

Now, the pc-sysfw:rom_only property will default
to false which enables flash by default.

All pc types below pc-1.1 set rom_only to true.
This prevents flash from being enabled on these
pc machine types.

For pc-1.1 rom_only will use the default (false),...
cbc5b5f3 02/22/2012 05:02 pm Jordan Justen

hw/pc: move rom init to pc_sysfw.c

Signed-off-by: Jordan Justen <>
Signed-off-by: Anthony Liguori <>