Statistics
| Branch: | Revision:

root / ui / spice-core.c @ bd5c51ee

History | View | Annotate | Download (25.6 kB)

# Date Author Comment
fd3bea3f 01/30/2013 12:14 pm Markus Armbruster

spice: Fix unchecked strdup() by converting to g_strdup()

Signed-off-by: Markus Armbruster <>
Reviewed-by: Eric Blake <>
Signed-off-by: Stefan Hajnoczi <>

4d454574 01/12/2013 06:17 pm Paolo Bonzini

qemu-option: move standard option definitions out of qemu-config.c

Signed-off-by: Paolo Bonzini <>

bfb82a28 01/04/2013 03:38 pm Stefan Hajnoczi

spice: drop incorrect vm_change_state_handler() opaque

The spice_server pointer is a global variable and
vm_change_state_handler() therefore does not use its opaque parameter.

The vm change state handler is added with a pointer to the spice_server
pointer. This is useless and we probably would not want 2 levels of...

27dd7730 12/20/2012 01:15 am Anthony Liguori

Merge remote-tracking branch 'bonzini/header-dirs' into staging

  • bonzini/header-dirs: (45 commits)
    janitor: move remaining public headers to include/
    hw: move executable format header files to hw/
    fpu: move public header file to include/fpu
    softmmu: move remaining include files to include/ subdirectories...
9c17d615 12/19/2012 09:32 am Paolo Bonzini

softmmu: move include files to include/sysemu/

Signed-off-by: Paolo Bonzini <>

1de7afc9 12/19/2012 09:32 am Paolo Bonzini

misc: move include files to include/qemu/

Signed-off-by: Paolo Bonzini <>

83c9089e 12/19/2012 09:31 am Paolo Bonzini

monitor: move include files to include/monitor/

Signed-off-by: Paolo Bonzini <>

caf71f86 12/19/2012 09:31 am Paolo Bonzini

migration: move include files to include/migration/

Signed-off-by: Paolo Bonzini <>

7b1b5d19 12/19/2012 09:31 am Paolo Bonzini

qapi: move include files to include/qobject/

Signed-off-by: Paolo Bonzini <>

28ecbaee 12/19/2012 09:31 am Paolo Bonzini

ui: move files to ui/ and include/ui/

Signed-off-by: Paolo Bonzini <>

afd0b409 12/17/2012 03:01 pm Marc-André Lureau

spice-qemu-char: register spicevmc ports during qemu_spice_init()

Do the delayed registration of spicevmc ports after Spice server is
initialized.

Signed-off-by: Gerd Hoffmann <>

938b8a36 12/17/2012 03:01 pm Uri Lublin

qxl+vnc: register a vm state change handler for dummy spice_server

When qxl + vnc are used, a dummy spice_server is initialized.
The spice_server has to be told when the VM runstate changes,
which is what this patch does.

Without it, from qxl_send_events(), the following error message is shown:...

9995c0b7 11/21/2012 03:46 pm Lei Li

Fix the inconsistency in x509-dh-key-file parameter

Commit c448e8552b0f6135dabddf944a7110f929c08320 (spice: tls
support) added options to the -spice command line. But there
is an inconsistency between the declaration of the option
'x509-dh-key-file' to -spice command line and its parameter...

67be6726 10/08/2012 01:15 pm Gerd Hoffmann

spice: raise requirement to 0.12

With the next qemu version (1.3) we are going to bump the qxl device
revision to 4. The new features available require a recent spice-server
version, so raise up the bar. Otherwise we would end up with different
qxl revisions depending on the spice-server version installed, which...

835cab85 09/05/2012 06:11 pm Christophe Fergeau

spice: abort on invalid streaming cmdline params

When parsing its command line parameters, spice aborts when it
finds unexpected values, except for the 'streaming-video' option.
This happens because the parsing of the parameters for this option
is done using the 'name2enum' helper, which does not error out...

f5bb039c 09/05/2012 06:11 pm Yonit Halperin

spice: notify spice server on vm start/stop

Spice server needs to know about the vm state in order to prevent
attempts to write to devices when they are stopped, mainly during
the non-live stage of migration.
Instead, spice will take care of restoring this writes, on the migration...

71d388d4 09/05/2012 06:11 pm Yonit Halperin

spice: notify on vm state change only via spice_server_vm_start/stop

QXLWorker->start/stop are deprecated since spice-server 0.11.2

Signed-off-by: Yonit Halperin <>
Signed-off-by: Gerd Hoffmann <>

2fdd16e2 09/05/2012 06:11 pm Yonit Halperin

spice migration: add QEVENT_SPICE_MIGRATE_COMPLETED

When migrating, libvirt queries the migration status, and upon migration
completions, it closes the migration src. On the other hand, when
migration is completed, spice transfers data from the src to destination...

61c4efe2 09/05/2012 06:11 pm Yonit Halperin

spice: add 'migrated' flag to spice info

The flag is 'true' when spice migration has completed on the src side.
It is needed for a case where libvirt dies before migration completes
and it misses the event QEVENT_SPICE_MIGRATE_COMPLETED.
When libvirt is restored and queries the migration status, it also needs...

8c957053 09/05/2012 06:11 pm Yonit Halperin

spice: adding seamless-migration option to the command line

The seamless-migration flag is required in order to identify
whether libvirt supports the new QEVENT_SPICE_MIGRATE_COMPLETED or not
(by default the flag is off).
New libvirt versions that wait for QEVENT_SPICE_MIGRATE_COMPLETED should turn on this flag....

4efee029 05/03/2012 11:45 am Alon Levy

spice_info: add mouse_mode

Add mouse_mode, either server or mouse, to qmp and hmp commands, based
on spice_server_is_server_mouse added in spice-server 0.10.3.

Signed-off-by: Alon Levy <>
Signed-off-by: Gerd Hoffmann <>

d0638b18 03/19/2012 02:12 pm Marc-André Lureau

spice: set spice uuid and name

This allows a Spice client to identify a VM

Signed-off-by: Gerd Hoffmann <>

ad1be899 03/19/2012 02:12 pm Alon Levy

spice: fix broken initialization

Commit 1b71f7c14fab6f00c2680d4489fbee7baf796e4f moved MODULE_INIT_QOM to
way before MODULE_INIT_MACHINE, thereby breaking assumptions made in
spice-core.c which registered both a type initializer and a machine
intializer....

339a475f 02/28/2012 06:22 pm Christophe Fergeau

spice: use error_report to report errors

Error message reporting during spice startup wasn't consistent, it was done
with fprintf(stderr, "") but sometimes the message didn't have a trailing
\n. Using error_report make the intent of the message clearer and deal...

35c63329 02/28/2012 06:22 pm Christophe Fergeau

Error out when tls-channel option is used without TLS

It's currently possible to setup spice channels using TLS when
no TLS port has been specified (ie TLS is disabled). This cannot
work, so better to error out in such a situation.

Signed-off-by: Gerd Hoffmann <>

4295e15a 02/27/2012 10:46 am Alon Levy

qxl: require spice >= 0.8.2

drop all ifdefs on SPICE_INTERFACE_QXL_MINOR >= 1 as a result,
any check for SPICE_SERVER_VERSION that is now always satisfied,
and SPICE_INTERFACE_CORE_MINOR >= 3 tests, because
0.8.2 has SPICE_INTERFACE_QXL_MINOR 1 and
SPICE_INTERFACE_CORE_MINOR 3....

f1f5f407 02/21/2012 11:36 am Daniel P. Berrange

Add SPICE support to add_client monitor command

With the acceptance of some new APIs to libspice-server.so it
is possible to add support for SPICE to the 'add_client'
monitor command, bringing parity with VNC. Since SPICE can
use TLS or plain connections, the command also gains a new...

faa98223 02/21/2012 11:36 am Yonit Halperin

spice: support ipv6 channel address in monitor events and in spice info

RHBZ #788444

CC: Gerd Hoffmann <>

Signed-off-by: Yonit Halperin <>
Signed-off-by: Gerd Hoffmann <>

83f7d43a 02/15/2012 05:39 pm Andreas Färber

qom: Unify type registration

Replace device_init() with generalized type_init().

While at it, unify naming convention: type_init([$prefix_]register_types)
Also, type_init() is a function, so add preceding blank line where
necessary and don't put a semicolon after the closing brace....

96b3d73f 10/31/2011 06:02 pm Anthony Liguori

Merge remote-tracking branch 'qmp/queue/qmp' into staging

Conflicts:
ui/spice-core.c

d1f29646 10/27/2011 04:48 pm Luiz Capitulino

qapi: Convert query-spice

Signed-off-by: Anthony Liguori <>
Signed-off-by: Luiz Capitulino <>

3bb781f3 10/25/2011 03:00 pm Alon Levy

ui/spice-core: fix segfault in monitor

Fix segfault if a qxl device is present but no spice command line
argument is given.

RHBZ 743251.

Signed-off-by: Alon Levy <>

08cc67f3 10/25/2011 03:00 pm Gerd Hoffmann

spice: fix file handle cleanup

Setting both read and write handlers to NULL in qemu_set_fd_handler
is not enougth to make qemu purge the file handle from the list.
We must set opaque to NULL too.

Signed-off-by: Gerd Hoffmann <>

edc5cb1a 10/25/2011 03:00 pm Yonit Halperin

spice: turn client_migrate_info to async

RHBZ 737921
Spice client is required to connect to the migration target before/as migration
starts. Since after migration starts, the target qemu is blocked and cannot accept new spice client
we trigger the connection to the target upon client_migrate_info command....

026f773f 10/25/2011 03:00 pm Yonit Halperin

spice: support the new migration interface (spice 0.8.3)

- call spice_server_migrate_(start|end|connect).
- register spice_migrate_connect completion callback

Signed-off-by: Yonit Halperin <>
Signed-off-by: Gerd Hoffmann <>

f9ab6091 10/25/2011 03:00 pm Jan Kiszka

spice: Convert core to QEMU thread API

No need to use pthread directly, we have proper abstractions for
identity checking.

Signed-off-by: Jan Kiszka <>
Signed-off-by: Gerd Hoffmann <>

7073693b 10/20/2011 02:23 pm Juan Quintela

migration: Export a function that tells if the migration has finished correctly

This will allow us to hide the state values.

Signed-off-by: Juan Quintela <>

22b626e2 09/07/2011 10:20 am Gerd Hoffmann

spice: workaround a spice server bug.

spice server might call the channel_event callback from spice server
thread context. Detect that and aquire iothread lock if needed,

7267c094 08/21/2011 07:01 am Anthony Liguori

Use glib memory allocation and free functions

qemu_malloc/qemu_free no longer exist after this commit.

Signed-off-by: Anthony Liguori <>

8df0c7e8 08/10/2011 07:52 pm Alon Levy

ui/spice-core: report compiled-version in info spice/query-spice

Signed-off-by: Alon Levy <>
Signed-off-by: Gerd Hoffmann <>

9e8dd451 07/23/2011 07:26 pm Jan Kiszka

notifier: Pass data argument to callback

This allows to pass additional information to the notifier callback
which is useful if sender and receiver do not share any other distinct
data structure.

Will be used first for the clock reset notifier.

Signed-off-by: Jan Kiszka <>...

df9cb669 07/20/2011 11:08 am Gerd Hoffmann

spice: add sanity check for spice ports

Make sure at least one port (port=.. or tls-port=...)
is specified. Also apply range checks to the port numbers.

Signed-off-by: Gerd Hoffmann <>

fba810f1 07/04/2011 04:35 pm Gerd Hoffmann

spice: catch spice server initialization failures.

When the spice server initialization fails report this and exit instead
of ignoring the error.

Signed-off-by: Gerd Hoffmann <>

d4970b07 06/06/2011 10:14 am Hans de Goede

spice: add option for disabling copy paste support

Some people want to be able disable spice's guest <-> client copy paste support
because of security considerations.

[ kraxel: drop old-version error message ]

48b3ed0a 06/06/2011 10:14 am Marc-André Lureau

spice: add SASL support

Turn on SASL support by appending "sasl" to the spice arguments, which
requires that the client use SASL to authenticate with the spice. The
exact choice of authentication method used is controlled from the
system / user's SASL configuration file for the 'qemu' service. This...

012b80d3 06/06/2011 10:14 am Gerd Hoffmann

spice: require spice 0.6.0 or newer.

This patch raises the minimum required spice version to 0.6.0 and drops
a few ifdefs.

0.6.0 is the first stable release with the current libspice-server API,
there shouldn't be any 0.5.x development versions deployed any more....

7bd427d8 03/21/2011 10:23 am Paolo Bonzini

change all rt_clock references to use millisecond resolution accessors

This was done with:

sed -i '/get_clock\>.*rt_clock/s/get_clock\>/get_clock_ms/' \
$(git grep -l 'get_clock\>.*rt_clock' )
sed -i '/new_timer\>.*rt_clock/s/new_timer\>/new_timer_ms/' \...
e866e239 01/24/2011 04:13 pm Gerd Hoffmann

spice/vnc: client migration.

Handle spice client migration, i.e. inform a spice client connected
about the new host and connection parameters, so it can move over the
connection automatically.

The monitor command has a not-yet used protocol argument simliar to...

7572150c 12/09/2010 03:23 pm Gerd Hoffmann

vnc/spice: add set_passwd monitor command.

This patch adds new set_password and expire_password monitor commands
which allows to change and expire the password for spice and vnc
connections. See the doc update patch chunk for details.

Signed-off-by: Gerd Hoffmann <>

a19cbfb3 12/09/2010 03:23 pm Gerd Hoffmann

spice: add qxl device

qxl is a paravirtual graphics card. The qxl device is the bridge
between the guest and the spice server (aka libspice-server). The
spice server will send the rendering commands to the spice client, which
will actually render them....

6f8c63fb 12/09/2010 03:23 pm Gerd Hoffmann

spice: connection events.

This patch adds support for connection events to spice. The events are
quite simliar to the vnc events. Unlike vnc spice uses multiple tcp
channels though. qemu will report every single tcp connection (aka
spice channel). If you want track spice sessions only you can filter...

cb42a870 12/09/2010 03:23 pm Gerd Hoffmann

spice: add qmp 'query-spice' and hmp 'info spice' commands.

The patch adds a 'query-spice' monitor command which returns
informations about the spice server configuration and also a list of
channel connections.

Signed-off-by: Gerd Hoffmann <>

43ae691e 11/16/2010 10:11 pm Anthony Liguori

Merge remote branch 'spice/bugfix.2' into staging

3e313753 11/09/2010 10:39 pm Gerd Hoffmann

spice: add audio

Add support for the spice audio interface. With this patch applied
audio can be forwarded over the network from/to the spice client. Both
recording and playback is supported.

The driver is first in the driver list, but the can_be_default flag is...

f61d6960 11/02/2010 01:42 pm Gerd Hoffmann

spice-core: fix warning when building with spice < 0.6.0

Signed-off-by: Gerd Hoffmann <>

3d6d306c 11/02/2010 01:42 pm Hans de Goede

spice-core: fix watching for write events

Signed-off-by: Gerd Hoffmann <>

c448e855 10/08/2010 01:49 pm Gerd Hoffmann

spice: tls support

Add options to the -spice command line switch to setup tls.

9f04e09e 10/08/2010 01:49 pm Yonit Halperin

spice: make compression configurable.

This patch adds options to the -spice command line switch to
configure image compression.

[ v2: speling fix in the documentation ]

17b6dea0 10/08/2010 01:49 pm Gerd Hoffmann

spice: add config options for channel security.

This allows to enforce tls or plaintext usage for certain spice
channels.

[ v2: code style fixup ]

333b0eeb 10/08/2010 01:49 pm Gerd Hoffmann

spice: add config options for the listening address

Make listening address configurable. Also add options to
force using IPv4 or IPv6.

84a23f25 10/08/2010 01:49 pm Gerd Hoffmann

spice: add misc config options

This patch adds a few more options to tweak spice server behavior.
The documentation update chunk has the details ;)

29b0040b 09/21/2010 07:36 pm Gerd Hoffmann

spice: core bits

Add -spice command line switch. Has support setting passwd and port for
now. With this patch applied the spice client can successfully connect
to qemu. You can't do anything useful yet though.

864401c2 09/21/2010 07:36 pm Gerd Hoffmann

spice: add keyboard

Open keyboard channel. Now you can type into the spice client and the
keyboard events are sent to your guest. You'll need some other display
like vnc to actually see the guest responding to them though.