pseries: Factor out check for out-of-bounds LIOBN
PAPR defines LIOBNs (Logical IO Bus Numbers) to be 32-bit, and we check forvalues that aren't in the code for H_PUT_TCE. This patch factors the checkinto spapr_tce_find_by_liobn(), which already checks if a 32-bit LIOBN...
pseries: Fix debug message for out-of-bounds address in H_PUT_TCE
Due to a brain outage, this message says "out-of-boards" instead of"out-of-bounds".
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>...
PPC: e500: initialize GPRs as per epapr
ePAPR defines the initial values of cpu registers.This patch initialize the GPRs as per ePAPR specification.
This resolves the issue of guest reboot/reset (guest hang on reboot).
Signed-off-by: Bharat Bhushan <bharat.bhushan@freescale.com>...
Merge remote-tracking branch 'afaerber-or/prep-up' into staging
Merge remote-tracking branch 'pmaydell/arm-devs.next' into staging
Message-id: 1367603215-5120-1-git-send-email-peter.maydell@linaro.org...
prep: Make System I/O port 0092 read/write
Port 0x0092 is documented as read/write, so for now return theendianness state instead of hardcoded 0x00.
Signed-off-by: Julio Guerra <guerr@julio.in>[AF: Extracted from larger port 0092 patch]Signed-off-by: Andreas Färber <andreas.faerber@web.de>
prep: Add ELF support for -bios
This prepares for switching from OpenHack'Ware to OpenBIOS.
While touching the error handling code, switch from aborting hw_error()to fprintf()+exit() and suppress failing without -bios for qtest.
Acked-by: Alexander Graf <agraf@suse.de>...
prep: Fix NIP reset value
The value was changed by commit 09d9828ace37ead29d510a7e24e63c2f15cd4b1c"PPC: fix hreset_vector for 60x, ...".
Change it back for prep machine to unbreak OpenHack'Ware.
Signed-off-by: Fabien Chouteau <chouteau@adacore.com>Signed-off-by: Andreas Färber <andreas.faerber@web.de>
i.MX: implement a more correct version of EPIT timer.
This patch is providing a complete version of the EPIT timer.
Note, however that the GPT timer in the same file is still notcomplete.
Signed-off-by: Jean-Christophe DUBOIS <jcd@tribudubois.net>Message-id: 1365624982-15647-1-git-send-email-jcd@tribudubois.net...
qdev: skip bus check for bus-less devices in qdev_unplug()
Since commit 2f7bd829db "qdev: Fix device_add bus assumptions" it's possible to device_add bus-less device, but if such device isunplugged it will dereference NULL parent_bus in qdev_unplug().
Fix it by taking in account that parent_bus might be NULL and...
virtio: add virtio_device_set_child_bus_name.
Add virtio_device_set_child_bus_name function.
It will be used with virtio-serial-x and virtio-scsi-x to set thechild bus name before calling virtio-x-device's init.
Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>...
scsi: add bus_name parameter to scsi_bus_new.
This adds the possibility to create a scsi-bus with a specified name.
Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>Acked-by: Paolo Bonzini <pbonzini@redhat.com>Tested-by: Cornelia Huck <cornelia.huck@de.ibm.com>...
virtio-serial: fix command line compatibility.
The bus name is wrong since the refactoring.
This keeps the behaviour of the command line.
Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>Tested-by: Cornelia Huck <cornelia.huck@de.ibm.com>Message-id: 1367330931-12994-5-git-send-email-fred.konrad@greensocs.com...
virtio-scsi: fix the command line compatibility.
Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>Tested-by: Cornelia Huck <cornelia.huck@de.ibm.com>Message-id: 1367330931-12994-6-git-send-email-fred.konrad@greensocs.com...
virtio-x-bus: force bus name to virtio-bus.
When the proxy id is set, this bus takes the name "id.0" which is expectedto be the virtio-device's first bus.
So force this name to "virtio-bus" as it is an internal bus.
Merge remote-tracking branch 'afaerber/qom-cpu' into staging
target-i386: Replace cpuid_*features fields with a feature word array
This replaces the feature-bit fields on both X86CPU and x86_def_tstructs with an array.
With this, we will be able to simplify code that simply does the sameoperation on all feature words (e.g. kvm_check_features_against_host(),...
Trivial grammar and spelling fixes
similiar -> similarrecieve -> receivetransfered -> transferredpreperation -> preparation
Most changes are in comments, one modifies a parameter name in a functionprototype.
The spelling fixes were made using codespell....
target-i386: Move APIC to ICC bus
It allows APIC to be hotplugged.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>Signed-off-by: Andreas Färber <afaerber@suse.de>
pc: Implement QEMUMachine::hot_add_cpu hook
Signed-off-by: Igor Mammedov <imammedo@redhat.com>Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>Signed-off-by: Andreas Färber <afaerber@suse.de>
target-i386: Introduce ICC bus/device/bridge
Provides a hotpluggable bus for APIC and CPU.
target-i386: Attach ICC bus to CPU on its creation
X86CPU should have parent bus so it could provide bus for child APIC.
target-i386: Replace MSI_SPACE_SIZE with APIC_SPACE_SIZE
Put APIC_SPACE_SIZE in a public header so that it can bereused elsewhere later.
kvmvapic: Make dependency on sysbus.h explicit
Allows kvmvapic to compile if sysbus.h is removed from apic_internal.h,from which it is indirectly included.sysbus.h will be removed from apic_internal.h after convertingAPICs to ICCDevice.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>...
pc: Update rtc_cmos on CPU hot-plug
It provides updated currently available CPUs count to BIOS on reboot.
acpi_piix4: Add infrastructure to send CPU hot-plug GPE to guest
target-i386: Introduce apic-id CPU property
The property is used from board level to set APIC ID for CPUs itcreates. Do so in a new pc_new_cpu() helper, to be reused for hot-plug.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>...
virtio-net: count VIRTIO_NET_F_MAC when calculating config_len
Commit 14f9b664 (hw/virtio-net.c: set config size using host features) tries tocalculate config size based on the host features. But it forgets theVIRTIO_NET_F_MAC were always set for qemu later. This will lead a zero config...
introduce a new qom device to deal with panicked event
pvpanic device is used to send guest panic event from guest to qemu.
When guest panic happens, pvpanic device driver will write a eventnumber to IO port 0x505(which is the IO port occupied by pvpanic device,...
pvpanic: pass configurable ioport to seabios
This lets seabios patch the corresponding SSDT entry.
Also add fw_cfg object to /machine/fw_cfg so we can referenceit elsewhere.
Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>Reviewed-by: Markus Armbruster <armbru@redhat.com>...
pvpanic: create pvpanic by default for machine 1.5
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>Reviewed-by: Markus Armbruster <armbru@redhat.com>Message-id: f840042f0e1205041f8feaf0d39ca639884f3a00.1366945969.git.hutao@cn.fujitsu.com...
qdev: Report errors collected during device realization
Better than just releasing the error object silently.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>Reviewed-by: Andreas Färber <afaerber@suse.de>Message-id: 517E68FC.6030400@siemens.comSigned-off-by: Anthony Liguori <aliguori@us.ibm.com>
pc_piix: remove undesired change in pc_init1
Introduced when applying commit f81222b (audio: look for the ISA andPCI buses, 2013-04-18).
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>Message-id: 1367330432-14417-1-git-send-email-pbonzini@redhat.com...
audio: enable PCI audio cards for all PCI-enabled targets
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>Message-id: 1366303444-24620-9-git-send-email-pbonzini@redhat.comSigned-off-by: Anthony Liguori <aliguori@us.ibm.com>
audio: look for the ISA and PCI buses
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>Message-id: 1366303444-24620-8-git-send-email-pbonzini@redhat.comSigned-off-by: Anthony Liguori <aliguori@us.ibm.com>
audio: replace audio card configuration with default-configs
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>Message-id: 1366303444-24620-6-git-send-email-pbonzini@redhat.comSigned-off-by: Anthony Liguori <aliguori@us.ibm.com>
adlib: qdev-ify
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>Message-id: 1366303444-24620-2-git-send-email-pbonzini@redhat.comSigned-off-by: Anthony Liguori <aliguori@us.ibm.com>
audio: remove the need for audio card CONFIG_* symbols
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>Message-id: 1366303444-24620-3-git-send-email-pbonzini@redhat.comSigned-off-by: Anthony Liguori <aliguori@us.ibm.com>
vmmouse: QOM'ify
Introduce type constant and cast macro to obsolete DO_UPCAST() andcontainer_of(). Prepares for ISA realizefn.
Remove reserved underscore from struct name while at it.
Signed-off-by: Andreas Färber <afaerber@suse.de>Signed-off-by: Andreas Färber <afaerber@suse.de>...
vmport: QOM'ify
Introduce type constant and cast macro to obsolete DO_UPCAST().Prepares for ISA realizefn.
Drop reserved underscore from struct name while at it.
wdt_ib700: QOM'ify
Introduce type constant and cast macro to obsolete DO_UPCAST().
Prepares for ISA realizefn.
Signed-off-by: Andreas Färber <afaerber@suse.de>Signed-off-by: Andreas Färber <afaerber@suse.de>Message-id: 1367093935-29091-21-git-send-email-afaerber@suse.de...
serial: QOM'ify ISA serial
Signed-off-by: Andreas Färber <afaerber@suse.de>Signed-off-by: Andreas Färber <afaerber@suse.de>Message-id: 1367093935-29091-16-git-send-email-afaerber@suse.de...
sga: QOM'ify
Introduce type constant and cast macro.
Signed-off-by: Andreas Färber <afaerber@suse.de>Signed-off-by: Andreas Färber <afaerber@suse.de>Message-id: 1367093935-29091-17-git-send-email-afaerber@suse.deSigned-off-by: Anthony Liguori <aliguori@us.ibm.com>
vga-isa: QOM'ify ISA VGA
Unify function naming scheme while at it.
m48t59: QOM'ify ISA M48T59 NVRAM
Introduce type constant and cast macro to obsolete DO_UPCAST() andcontainer_of().
Signed-off-by: Andreas Färber <afaerber@suse.de>Signed-off-by: Andreas Färber <afaerber@suse.de>Message-id: 1367093935-29091-8-git-send-email-afaerber@suse.de...
mc146818rtc: QOM'ify
Signed-off-by: Andreas Färber <afaerber@suse.de>Reviewed-by: Igor Mammedov <imammedo@redhat.com>Signed-off-by: Andreas Färber <afaerber@suse.de>...
ne2000-isa: QOM'ify
Signed-off-by: Andreas Färber <afaerber@suse.de>Signed-off-by: Andreas Färber <afaerber@suse.de>Message-id: 1367093935-29091-10-git-send-email-afaerber@suse.de...
parallel: QOM'ify
Signed-off-by: Andreas Färber <afaerber@suse.de>Signed-off-by: Andreas Färber <afaerber@suse.de>Message-id: 1367093935-29091-11-git-send-email-afaerber@suse.de...
pc: QOM'ify port 92
Signed-off-by: Andreas Färber <afaerber@suse.de>Signed-off-by: Andreas Färber <afaerber@suse.de>Message-id: 1367093935-29091-12-git-send-email-afaerber@suse.de...
pckbd: QOM'ify
Signed-off-by: Andreas Färber <afaerber@suse.de>Signed-off-by: Andreas Färber <afaerber@suse.de>Message-id: 1367093935-29091-13-git-send-email-afaerber@suse.de...
pcspk: QOM'ify
Signed-off-by: Andreas Färber <afaerber@suse.de>Signed-off-by: Andreas Färber <afaerber@suse.de>Message-id: 1367093935-29091-14-git-send-email-afaerber@suse.de...
sb16: QOM'ify
Signed-off-by: Andreas Färber <afaerber@suse.de>Signed-off-by: Andreas Färber <afaerber@suse.de>Message-id: 1367093935-29091-15-git-send-email-afaerber@suse.de...
cirrus_vga: QOM'ify ISA Cirrus VGA
Signed-off-by: Andreas Färber <afaerber@suse.de>Signed-off-by: Andreas Färber <afaerber@suse.de>Message-id: 1367093935-29091-3-git-send-email-afaerber@suse.de...
fdc: QOM'ify ISA floppy controller
Introduce type constant and cast macro to obsolete DO_UPCAST().Reuse type constant for PC machine compatibility settings.
i82374: QOM'ify
Signed-off-by: Andreas Färber <afaerber@suse.de>Signed-off-by: Andreas Färber <afaerber@suse.de>Message-id: 1367093935-29091-5-git-send-email-afaerber@suse.de...
i8259: QOM cleanups
Eliminate DO_UPCAST() for PICCommonState. Prepares for ISA realizefn.
Also give the i8259_common type registration functions unique nameswhile at it.
ide: QOM'ify ISA IDE
Introduce type constant and cast macro to obsolete DO_UPCAST().Add missing braces.
Signed-off-by: Andreas Färber <afaerber@suse.de>Signed-off-by: Andreas Färber <afaerber@suse.de>Message-id: 1367093935-29091-7-git-send-email-afaerber@suse.de...
applesmc: QOM'ify
Add a typedef for the state struct and rename from Status to State.Add type constant and cast macro to obsolete DO_UPCAST().
virtio-net: unbreak the minix guest
Multiqueue patchset conditionally add control vq only when guest negotiate thefeature. Though the spec is not clear on this but it breaks the minix guestsince it will identify the ctrl vq even if it does not support it. Though this...
Merge remote-tracking branch 'alon/libcacard_ccid.2' into staging
Message-id: 20130426234357.GA12457@garlic.tamiSigned-off-by: Anthony Liguori <aliguori@us.ibm.com>
sparc64: use direct interrupt mapping for PCI devices
Every PCI Slot in PBM has 4 directly mapped IRQ lines.Use the IRQ routing schema 0bssnn (Bus, Slot, interrupt Number)described in Section 19.3.3 of UltraSPARC™-IIi User's Manual.
Please note that this patch requires the OpenBIOS counterpart patch....
sparc64: fix loosing interrupts
- clear interrupts only on writing to the interrupt clear registers- don't overwrite a currently active interrupt request- use the correct addresses for the interrupt clear registers (section 19.3.3.3 of the UltraSPARC™-IIi User’s Manual)...
sparc64: allow 64 IRQ lines
According to UltraSPARC™-IIi User’s Manual, PBM has 64 IRQ lines.
Signed-off-by: Artyom Tarasenko <atar4qemu@gmail.com>Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
ccid: Fix crash when backend isn't specified
Reproducer:
./x86_64-softmmu/qemu-system-x86_64 -device usb-ccid,id=ccid0 -usb -device ccid-card-emulated -monitor stdio
Signed-off-by: Cole Robinson <crobinso@redhat.com>Reviewed-by: Alon Levy <alevy@redhat.com>
Merge branch 'ppc-for-upstream' of git://github.com/agraf/qemu
pseries: Generate device paths for VIO devices
This patch implements a get_dev_path qdev hook for the pseries paravirtualVIO bus. With upcoming savevm support, this will become very important forscsi disks hanging of VIO virtual SCSI adapters. scsibus_get_dev_path...
PPC: mac newworld: fix cpu NIP reset value
On -M mac99, we can run 970 CPUs. However, these CPUs define the initialinstruction pointer they start execution at as part of their bootup protocol,so effectively it's up to the board to decide where they start....
pseries: Fixes and enhancements to L1 cache properties
PAPR requires that the device tree's CPU nodes have several propertieswith information about the L1 cache. We already create two of theseproperties, but with incorrect names - "[id]cache-block-size" instead...
pseries: Fix some small errors in XICS logic
Under certain circumstances the emulation for the pseries "XICS" interruptcontroller was clearing a pending interrupt from the XISR register, withoutalso clearing the corresponding priority variable. This will cause...
pseries: Convert VIO code to QOM style type safe(ish) casts
Curerntly the pseries VIO device code contains quite a few explicituses of DO_UPCAST and plain C casts. This is (obviously) type unsafe,and not the conventional way of doing things in the QOM model. This...
PPC: e500: advertise 4.2 MPIC only if KVM supports EPR
Older KVM versions don't support EPR which breaks guests when we announceMPIC variants that support EPR.
Catch that case and expose only MPIC version 2.0 which tells the guest thatwe don't support the EPR capability yet....
PPC: Remove env->hreset_excp_prefix
This value is not needed if we use correctly the MSR[IP] bit.
excp_prefix is always 0x00000000, except when the MSR[IP] bit isimplemented and set to 1, in that case excp_prefix is 0xfff00000.
The handling of MSR[IP] was already implemented but not used at reset...
Enable kvm emulated watchdog
Enable the KVM emulated watchdog if KVM supports (use thecapability enablement in watchdog handler). Also watchdog exit(KVM_EXIT_WATCHDOG) handling is added.Watchdog state machine is cleared whenever VM state changes to running....
virtio-rng-s390: add properties.
I don't see any reason why these properties are missing.
Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>
Note: Need to apply virtio-rng-refactoring first!Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>Signed-off-by: Alexander Graf <agraf@suse.de>
S390: IPL: Use different firmware for different machines
We have a virtio-s390 and a virtio-ccw machine in QEMU. Both use vastlydifferent ways to do I/O. Having the same firmware blob for both doesn'treally make any sense.
Instead, let's parametrize the firmware file name, so that we can have...
S390: CCW: Use new, working firmware by default
Since we now have working firmware for s390-ccw in the tree, we candefault to it on our s390-ccw machine, rendering it more useful.
Signed-off-by: Alexander Graf <agraf@suse.de>
S390: Make IPL reset address dynamic
We can have different load addresses for different blobs we boot with.Make the reset IP dynamic, so that we can handle things more flexibly.
S390: IPL: Support ELF firmware
Our firmware blob is always a raw file that we load at a fixed address today.Support loading an ELF blob instead that we can map high up in memory.
This way we don't have to be so conscious about size constraints.
virtio: Fix compilation without CONFIG_VHOST_SCSI
Signed-off-by: Ed Maste <emaste@freebsd.org>Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
console: qom-ify QemuConsole
Just the minimal bits to turn QemuConsoles into Objects.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
console: add device link to QemuConsoles
So it is possible to figure which qemu console displays which device.
console: zap ds arg from register_displaychangelistener
We don't have multiple DisplayStates any more,so passing it in as argument is not needed.
virtio-ccw: Check indicators location.
If a guest neglected to register (secondary) indicators but still runswith notifications enabled, we might end up writing to guest zero;avoid this by checking for valid indicators and only writing to theguest and generating an interrupt if indicators have been setup....
pc: Kill the "use flash device for BIOS unless KVM" misfeature
Use of a flash memory device for the BIOS was added in series "[PATCHv10 0/8] PC system flash support", commit 4732dca..1b89faf, v1.1.
Flash vs. ROM is a guest-visible difference. Thus, flash use had to...
pc: Inline pc_init_pci_1_3() into pc_init_pci_1_2()
Just to make the commit after next easier to review.
Signed-off-by: Markus Armbruster <armbru@redhat.com>Message-id: 1365780303-26398-2-git-send-email-armbru@redhat.comSigned-off-by: Anthony Liguori <aliguori@us.ibm.com>
pc: Split pc_init_pci_1_0() off pc_init_pci_1_2()
Just to make the next commit easier to review.
Signed-off-by: Markus Armbruster <armbru@redhat.com>Message-id: 1365780303-26398-3-git-send-email-armbru@redhat.comSigned-off-by: Anthony Liguori <aliguori@us.ibm.com>
Merge remote-tracking branch 'alon/libcacard_ccid.1' into staging
virtio: cleanup: init and exit function.
This clean the init and the exit functions and rename virtio_common_cleanupto virtio_cleanup.
Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>Message-id: 1366791683-5350-7-git-send-email-fred.konrad@greensocs.com...
virtio-rng: cleanup: use QOM casts.
As the virtio-rng-pci, virtio-rng-s390 and virtio-rng-ccw areswitched to the new API, we can use QOM casts.
Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>Reviewed-by: Andreas Färber <afaerber@suse.de>Reviewed-by: Andreas Färber <afaerber@suse.de>...
virtio-bus: add new functions.
This add two functions: * virtio_bus_set_vdev_config. * virtio_bus_set_vdev_feature.
Needed by virtio-ccw.
Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>Message-id: 1366791683-5350-2-git-send-email-fred.konrad@greensocs.com...
virtio-bus: make virtio_x_bus_new static.
virtio_x_bus_new are only used in file scope.So this make them static.
Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>Message-id: 1366791683-5350-3-git-send-email-fred.konrad@greensocs.comSigned-off-by: Anthony Liguori <aliguori@us.ibm.com>
virtio-pci: cleanup.
This remove the init, exit functions as they are no longer used.
Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>Message-id: 1366791683-5350-4-git-send-email-fred.konrad@greensocs.comSigned-off-by: Anthony Liguori <aliguori@us.ibm.com>
virtio: remove the function pointer.
This remove the function pointer in VirtIODevice, and use onlyVirtioDeviceClass function pointer.
Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>Message-id: 1366791683-5350-5-git-send-email-fred.konrad@greensocs.com...
virtio: remove virtiobindings.
This remove virtio-bindings, and use class instead.
Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>Message-id: 1366791683-5350-6-git-send-email-fred.konrad@greensocs.comSigned-off-by: Anthony Liguori <aliguori@us.ibm.com>
virtio-rng: add virtio-rng device.
Create virtio-rng-device which extends virtio-device, so it can be connected onvirtio-bus.
Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>Tested-by: Cornelia Huck <cornelia.huck@de.ibm.com>Acked-by: Amit Shah <amit.shah@redhat.com>...
virtio-rng-pci: switch to the new API.
Here the virtio-rng-pci is modified for the new API. The devicevirtio-rng-pci extends virtio-pci. It creates and connects a virtio-rng-deviceduring the init. The properties are not changed.
The virtio_pci_reset function, is removed as no longer used....
virtio-rng-s390: switch to the new API.
Here the virtio-rng-s390 is modified for the new API. The devicevirtio-rng-s390 extends virtio-s390-device as before. It creates andconnects a virtio-rng during the init. The properties are not modified.
virtio-rng-ccw: switch to the new API.
Here the virtio-rng-ccw is modified for the new API. The devicevirtio-rng-pci extends virtio-pci. It creates and connects a virtio-rng-deviceduring the init. The properties are not changed.
virtio-rng: cleanup: init and exit functions.
This remove old init and exit function as they are no longer needed.
virtio-rng: cleanup: remove qdev field.
The qdev field is no longer needed, just drop it.
Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>Tested-by: Cornelia Huck <cornelia.huck@de.ibm.com>Acked-by: Amit Shah <amit.shah@redhat.com>Message-id: 1366790881-3026-8-git-send-email-fred.konrad@greensocs.com...